Split out latex backend into a separate module#1111
Merged
jaygambetta merged 10 commits intoQiskit:masterfrom Oct 24, 2018
Merged
Split out latex backend into a separate module#1111jaygambetta merged 10 commits intoQiskit:masterfrom
jaygambetta merged 10 commits intoQiskit:masterfrom
Conversation
This commit splits out the latex circuit visualization module into a separate module. This completes the decomposition of all the circuit visualization backends into separate modules. Fixes Qiskit#1104
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
The text circuit drawer backend is not a public interface. We don't want people to be confused and assume that we have a public api contract with the public classes and functions in the module. This commit just renames the module to indicate it's a private module.
mtreinish
force-pushed
the
split-latex-drawer
branch
from
6f681f4 to
18f71de
Compare
jaygambetta
previously approved these changes
Oct 23, 2018
Member
Author
|
@jaygambetta the matplotlib backend was already split out into it's own module in #1105 |
Member
|
yeah i realized |
Member
|
I think we just add a note in the changelog and I think we are good. |
ajavadia
previously approved these changes
Oct 24, 2018
Member
Author
|
I will push a commit adding this move to the changelog right now |
jaygambetta
approved these changes
Oct 24, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Split out latex backend into a separate module This commit splits out the latex circuit visualization module into a separate module. This completes the decomposition of all the circuit visualization backends into separate modules. Fixes Qiskit#1104 * Make text drawer module private The text circuit drawer backend is not a public interface. We don't want people to be confused and assume that we have a public api contract with the public classes and functions in the module. This commit just renames the module to indicate it's a private module. * Add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit splits out the latex circuit visualization module into a
separate module. This completes the decomposition of all the circuit
visualization backends into separate modules.
Details and comments
Fixes #1104